search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Dashboard] [Controls] Controls overwritten on navigation #193611

Closed Heenawter closed 1 month ago

Heenawter commented 1 month ago

Describe the bug: This is the bug that just keeps on giving. Unfortunately, I think we reintroduced it with either (1) the control group + dashboard integration or (2) the start of the dashboard refactor.

Steps to reproduce:

  1. Create a dashboard with controls with either a links panel or a markdown link to another dashboard
  2. Try navigating
  3. Notice that controls get replaced in the destination dashboard with the controls from the source dashboard :fire:

Expected behavior: The controls should get updated to the controls from the destination dashboard

Screenshots (if relevant):

https://github.com/user-attachments/assets/e0d0143a-6b37-4111-9c56-644155b57696

Any additional context: I honestly think it might just be an update issue - hence the LOE. It doesn't look like the control group re-renders at all after navigation. We need to tie the control group renderer to update when the dashboard ID changes.

elasticmachine commented 1 month ago

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter commented 1 month ago

Closing oops - I was running the https://github.com/elastic/kibana/pull/193220 PR locally and turns out it's from there. This isn't on main yet. Phew! 😆