search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

Fix memory leak in task manager task runner #193612

Closed mikecote closed 1 day ago

mikecote commented 1 day ago

In this PR, I'm fixing a memory leak that was introduced in https://github.com/elastic/kibana/pull/190093 where every task runner class object wouldn't free up in memory because it subscribed to the pollIntervalConfiguration$ observable. To fix this, I moved the observable up a class into TaskPollingLifecycle which only gets created once on plugin start and then pass down the pollInterval value via a function call the task runner class can call.

elasticmachine commented 1 day ago

Pinging @elastic/response-ops (Team:ResponseOps)

kibana-ci commented 1 day ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

kibanamachine commented 1 day ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation