elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[maps embeddable] fix map layers disappear from map panel when using session storage to continue editing a dashboard #193629

Open nreese opened 1 day ago

nreese commented 1 day ago

Closes https://github.com/elastic/kibana/issues/190468 and https://github.com/elastic/kibana/issues/193601

Dashboard unsaved changes for a panel are obtained from the embeddable comparator subject for each comparator. If comparator subject does not return a value, then this information is lost when returning to a dashboard with unsaved changes. This is why layers and filters where disappearing from a map when returning to a dashboard with unsaved changes. This PR resolves this issue by providing comparator subjects and setters for savedObjectId, attributes, and mapSettings.

PR also resolves issue of passing props from MapRenderer component into map embeddable. Instead of passing props via state, props should be passed from MapRenderer parent api.

elasticmachine commented 1 day ago
:robot: Jobs for this PR can be triggered through checkboxes. :construction: :information_source: To trigger the CI, please tick the checkbox below :point_down: - [ ] Click to trigger **kibana-pull-request** for this PR!
nreese commented 1 day ago

/ci

nreese commented 23 hours ago

/ci

nreese commented 22 hours ago

/ci

kibana-ci commented 21 hours ago

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 1236 1237 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.0MB 3.0MB +1.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
maps 28 27 -1

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream