elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.62k stars 8.22k forks source link

[Security Solution] Makes `rule_source` a required field in `RuleResponse` #193636

Closed dplumlee closed 1 month ago

dplumlee commented 1 month ago

Resolves https://github.com/elastic/kibana/issues/180270

Summary

Sets rule_source to be a required field in the RuleResponse type

Checklist

Delete any items that are not applicable to this PR.

For maintainers

elasticmachine commented 1 month ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

elasticmachine commented 1 month ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 1 month ago

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

banderror commented 1 month ago

@maximpn @dplumlee FYI this PR interferes with https://github.com/elastic/kibana/pull/194132 - when one of them gets merged first, the other one will need to be rebased on top to make sure output OAS bundles are properly regenerated

dplumlee commented 1 month ago

@elasticmachine merge upstream

dplumlee commented 1 month ago

@elasticmachine merge upstream

banderror commented 1 month ago

@elasticmachine merge upstream

dplumlee commented 1 month ago

@elasticmachine merge upstream

kibana-ci commented 1 month ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.6MB 20.6MB -41.0B

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

cc @dplumlee

kibanamachine commented 1 month ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11221182473

kibanamachine commented 1 month ago

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation