elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

[Dashboard] Cleanup services #193644

Open Heenawter opened 21 hours ago

Heenawter commented 21 hours ago

Closes https://github.com/elastic/kibana/issues/167437

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

elasticmachine commented 21 hours ago
:robot: Jobs for this PR can be triggered through checkboxes. :construction: :information_source: To trigger the CI, please tick the checkbox below :point_down: - [ ] Click to trigger **kibana-pull-request** for this PR!
kibana-ci commented 20 hours ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
dashboard 562 530 -32

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dashboard 123 124 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 481.2KB 397.8KB -83.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff errors
dashboard 26.9KB 96.0KB +69.1KB ❌ 44.2KB over limit
Unknown metric groups #### API count | id | [before](https://github.com/elastic/kibana/commit/dfbd7de3f53cae4b81d8643283f106cbf16e3415) | [after](https://github.com/elastic/kibana/commit/fdeb6f6584d1f3e4ac079ad5eeeeb10efd3eb754) | diff | | --- | --- | --- | --- | | `dashboard` | 128 | 129 | +1 | #### async chunk count | id | [before](https://github.com/elastic/kibana/commit/dfbd7de3f53cae4b81d8643283f106cbf16e3415) | [after](https://github.com/elastic/kibana/commit/fdeb6f6584d1f3e4ac079ad5eeeeb10efd3eb754) | diff | | --- | --- | --- | --- | | `dashboard` | 15 | 11 | -4 | #### References to deprecated APIs | id | [before](https://github.com/elastic/kibana/commit/dfbd7de3f53cae4b81d8643283f106cbf16e3415) | [after](https://github.com/elastic/kibana/commit/fdeb6f6584d1f3e4ac079ad5eeeeb10efd3eb754) | diff | | --- | --- | --- | --- | | `dashboard` | 40 | 31 | -9 |

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream