[Project nav] Add toggle full screen button

tsullivan commented 1 month ago

Summary

Epic: https://github.com/elastic/kibana-team/issues/1019

Checklist

Delete any items that are not applicable to this PR.

[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
[ ] Documentation was added for features that require explanation or tutorials
[ ] Unit or functional tests were updated or added to match the most common scenarios
[ ] Flaky Test Runner was used on any tests changed
[ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
[ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
[ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
[ ] This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

[ ] This was checked for breaking API changes and was labeled appropriately

elasticmachine commented 1 month ago

:robot: Jobs for this PR can be triggered through checkboxes. :construction: :information_source: To trigger the CI, please tick the checkbox below :point_down: - [ ] Click to trigger **kibana-pull-request** for this PR!

kibana-ci commented 1 month ago

:broken_heart: Build Failed

Buildkite Build
Commit: ea745ce91bf1b8cb66b6a2aa0bca8190bc0e878c
Interpreting CI Failures

Failed CI Steps

Quick Checks

History

To update your PR or re-run it, just comment with: @elasticmachine merge upstream

elasticmachine commented 3 weeks ago

:broken_heart: Build Failed

Buildkite Build
Commit: a9923918071ba309e1f0f7bff9d902ac86aecc0e

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #65 / dashboard app - group 2 full screen mode available in view mode
[job] [logs] FTR Configs #65 / dashboard app - group 2 full screen mode available in view mode
[job] [logs] FTR Configs #11 / dashboard app - group 6 dashboard snapshots compare TSVB snapshot
[job] [logs] FTR Configs #11 / dashboard app - group 6 dashboard snapshots compare TSVB snapshot
[job] [logs] FTR Configs #56 / discover feature controls discover feature controls security global discover all privileges shows save button
[job] [logs] FTR Configs #56 / discover feature controls discover feature controls security global discover all privileges shows save button
[job] [logs] Jest Integration Tests #3 / incompatible_cluster_routing_allocation retries the INIT action with a descriptive message when cluster settings are incompatible
[job] [logs] Jest Integration Tests #3 / incompatible_cluster_routing_allocation retries the INIT action with a descriptive message when cluster settings are incompatible
[job] [logs] FTR Configs #81 / maps app maps loaded from sample data ecommerce "before all" hook for "should load layers"
[job] [logs] FTR Configs #81 / maps app maps loaded from sample data ecommerce "before all" hook for "should load layers"
[job] [logs] Jest Integration Tests #3 / migration v2 - read batch size does not reduce the read batchSize in half if no batches exceeded maxReadBatchSizeBytes
[job] [logs] Jest Integration Tests #3 / migration v2 - read batch size does not reduce the read batchSize in half if no batches exceeded maxReadBatchSizeBytes
[job] [logs] Jest Integration Tests #3 / migration v2 - read batch size reduces the read batchSize in half if a batch exceeds maxReadBatchSizeBytes
[job] [logs] Jest Integration Tests #3 / migration v2 - read batch size reduces the read batchSize in half if a batch exceeds maxReadBatchSizeBytes
[job] [logs] Jest Integration Tests #3 / migration v2 migrates saved objects normally with multiple ES nodes
[job] [logs] Jest Integration Tests #3 / migration v2 migrates saved objects normally with multiple ES nodes
[job] [logs] FTR Configs #28 / X-Pack Accessibility Tests - Group 3 Maps app Accessibility displays exit full screen logo button
[job] [logs] FTR Configs #28 / X-Pack Accessibility Tests - Group 3 Maps app Accessibility displays exit full screen logo button

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`core`	447	587	+140
`dashboard`	667	528	-139
total			+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`core`	60.9KB	60.9KB	-37.0B
`dashboard`	637.3KB	453.3KB	-184.0KB
`maps`	3.0MB	3.0MB	-167.0B
total			-184.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff	errors
`core`	450.0KB	634.9KB	+184.9KB	❌ 83.5KB over limit
`dashboard`	50.3KB	50.3KB	-58.0B
total			+184.8KB

History

:broken_heart: Build #243299 failed 06f713903c61ecf7ee87fe3fddc99ad623c62bac
:broken_heart: Build #240501 failed f281e301e2b04c1d8e5ecdb385d7f6c0737edd99
:broken_heart: Build #240493 failed 6a963c3986c327857a210b175f8de8ab8f56de6f

elastic / kibana