search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.61k stars 8.22k forks source link

[Discover] Implement mechanism for managing flyouts #194239

Open davismcphee opened 1 month ago

davismcphee commented 1 month ago

Discover uses several flyouts (e.g. doc viewer, ES|QL help, Lens editor), and they can overlap if not properly managed, for example when two push flyouts are opened at once:

We implemented a quick fix to address this problem in #193865, but we should figure out a more robust way to manage flyouts longer term, which can also be used by Discover extensions that show flyouts (e.g. cell renderer with a link that opens a flyout). One idea would be to create something like a central "flyout manager" that's responsible for ensuring only one flyout is opened at once in Discover.

elasticmachine commented 1 month ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal commented 1 month ago

Linking https://github.com/elastic/eui/issues/8042, because ideally we wouldn't need to deal with this on plugin level , and also related: https://github.com/elastic/eui/issues/7443