search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.82k stars 8.2k forks source link

[Response Ops][Alerting] Fix typing for action `uuid` #195255

Open ymao1 opened 2 weeks ago

ymao1 commented 2 weeks ago

With this PR, we added a uuid to the rule action and a migration that sets the uuid for existing rules.

From the PR summary:

Initialy uuid in RuleAction was not optional but as it created tons of changes on types and tests we decided to add it optional. It is still required in RawRuleAction which reflects the action object in Kibana SO.

This leaves the UUID typed as optional in the code when it's not actually optional and it's always set. We should investigate the effort to fix this.

elasticmachine commented 2 weeks ago

Pinging @elastic/response-ops (Team:ResponseOps)