elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.6k stars 8.21k forks source link

[`@kbn/telemetry-tools`] `--path` option is broken #195469

Open afharo opened 3 weeks ago

afharo commented 3 weeks ago

Running node scripts/telemetry_check with the --path option is broken. Logs pasted below:

➜  kibana git:(main) node scripts/telemetry_check --path=x-pack/plugins/observability_solution/apm/server/lib/apm_telemetry/index.ts
✔ Checking .telemetryrc.json files
✔ Extracting Collectors
✔ Checking collectors in --path are not excluded
✔ Checking Compatible collector.schema with collector.fetch type
❯ Checking Matching collector.schema against stored json files
  ✔ Checking in /Users/afharo/Developer/elastic/kibana/src/plugins/
  ✔ Checking in /Users/afharo/Developer/elastic/kibana/packages/
  ✖ The following changes must be persisted in /Users/afharo/Developer/elastic/kibana/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json file. Run 'node scripts/telemetry_check --fix' to update.
    {
    "properties": {}
    }
  ◼ Checking in /Users/afharo/Developer/elastic/kibana/x-pack/plugins/monitoring/server/telemetry_collection/
ERROR Unhandled exception!
ERROR Error: The following changes must be persisted in /Users/afharo/Developer/elastic/kibana/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json file. Run 'node scripts/telemetry_check --fix' to update.
      {
        "properties": {}
      }
          at Task.task [as taskFn] (check_matching_schemas_task.ts:26:17)
          at Task.run (/Users/afharo/Developer/elastic/kibana/node_modules/listr2/dist/index.cjs:2143:11)
elasticmachine commented 3 weeks ago

Pinging @elastic/kibana-core (Team:Core)