elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.82k stars 8.2k forks source link

Project Navigation: Add support for item openInNewTab key #195656

Open TattdCodeMonkey opened 1 week ago

TattdCodeMonkey commented 1 week ago

The NodeDefiniton type defines the openInNewTab property, but this is not currently support in the Shared UX project navigation component. Enabling support for this would allow solution teams to set this property and have links render the external icon and they would open in a new tab when clicked.

We would like to use this in Serverless Search for linking to cloud app links.

ie: Image

Alternatively we could update the project navigation to always treat nodes with cloudLink as open in a new tab, since it takes the user out of Kibana. This would meet the same requirement.

With either solution, a sidenav item that opens in a new tab would need to show the popout icon on the right side of the item to communicate to the user that the link will open a new tab.

elasticmachine commented 1 week ago

Pinging @elastic/appex-sharedux (Team:SharedUX)

sebelga commented 1 week ago

@ryankeairns @kevinsweet We already discussed this (and decided not to open the Cloud links in a separate tab) but apparently the Search teams would like to change the behaviour to open the cloud links in new tabs.

If we change it, that will impact the other 2 solutions. Could you give your input on the change and how do we proceed? thanks!

ryankeairns commented 1 week ago

I also vaguely recall starting with icons / external links then, somewhere along the way, changing course in order to make the flow feel like a single application even though we know them as two distinct 'things' - Cloud and Kibana.

Subjectively, these particular items - under Project settings - strike me as things you would not typically see as external, popout links. It's reasonable that users might want to open these or other links in a new tab, but that could be possible through a browser's Ctrl+click (i.e. open in tab) behavior. With that in mind, we could leave this as-is and look to ensure the aforementioned browser behavior is not 'broken' as seems to be the case today.

linyaru commented 1 week ago

make the flow feel like a single application even though we know them as two distinct 'things' - Cloud and Kibana.

My 2 cents: it's not about what we want the flow to feel like, it's that subjectively clicking on these links will take the user to a screen that's completely different with no clear indication of how to get back other than clicking a browser back button, and thereby not like single application

kevinsweet commented 1 week ago

just to split things off, I think users/roles is agreed upon to not be shown

now there's a separate question of the other two menu items, and if they should be tabs

my feeling is that each exp has some reason: (no tab) pretend to be single app for seamless vs (tab) visually prepare the user for the giant journey hop to a new app with a separate nav, and keep their current context alive.

Given that, is the tiebreaker to embrace the simplest rule possible? Which would seemingly be to always open in a new tab if user is leaving Kibana.

linyaru commented 1 week ago

Yes, please treat this behaviour as a separate discussion from where "Users and Roles" should be located.

petrklapka commented 1 week ago

@kevinsweet and @ryankeairns @ek-so - This needs a "guideline". It's another perfect example of an easy feature, but one that causes inconsistency in the UX. We need to align solutions on how this will behave product wide.

ek-so commented 3 days ago

Hey @petrklapka @kevinsweet @ryankeairns I dropped this ask plus a couple of other issues and the context I was able to find regarding updates for the new nav into this design issue. Please feel free to add there any other considerations I might have missed.