elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.78k stars 8.19k forks source link

[ResponseOps][Connectors] prevent or allow connectors with pre/post save/delete hooks from being used as pre-configured connectors? #195824

Open pmuellr opened 23 hours ago

pmuellr commented 23 hours ago

based on PR comments:

Originally this was titled "prevent connectors" without the "or allow", but I guess we're still figuring it out, and it looks like we will likely need to allow them.

If we wanted to prevent themwe should be able to - at startup - mark pre-configured connectors as disabled (or unusable, somehow), if their connectorType has pre-save/post-save/post-delete hooks. Since the hooks will never be called since the connector is never "created" or "deleted" via API.

If we want to allow them, we need to figure out:

Once we figure out which way to go, we can aim this issue down that track, or leave this as discussion and create a new one ...

elasticmachine commented 23 hours ago

Pinging @elastic/response-ops (Team:ResponseOps)

pmuellr commented 22 hours ago

Note this was a little premature - actually an inference connector DOES need to be pre-configured - some conversation here:

https://github.com/elastic/kibana/pull/189027#issuecomment-2406133287

We can use this issue to discuss how this can happen, I'll swizzle the title and top comment ...