search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

Option to disable "Exists" on dashboard Option lists (dropdowns) #195829

Open morrone opened 1 month ago

morrone commented 1 month ago

Describe the feature:

We would like to see an option to allow us to disable the "Exists" option in the dashboard Option lists (dropdowns). It would be sufficient to have this option only available when the Option list is in the "Only allow a single selection" mode. It might not make as much sense to remove it in multi-selection mode.

Describe a specific use case for the feature:

Imagine a dashboard that shows information about a single node of a cluster, and there is an Option list at the top of the dashboard that allow the user to select a "Node name". Since the dashboard is designed around a single node's worth of data, if the search results contain data from multiple nodes, the visualizations on the dashboard will all become nonsensical. The drop down mostly enforces selecting a single node at a time, except that "Exists" allows the user to shoot themselves in the foot and get results that are very confusing.

@IanLee1521

IanLee1521 commented 1 month ago

Thanks Chris. cc/ @davidherst

elasticmachine commented 1 month ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine commented 1 month ago

Pinging @elastic/kibana-presentation (Team:Presentation)

teresaalvarezsoler commented 4 weeks ago

@andreadelrio @Heenawter I'm wondering if "Exists" makes any sense when the user selects "single selection" for a control since it is effectively allowing the user to multi-select. Should we just remove it in this case?

Heenawter commented 4 weeks ago

I'm wondering if "Exists" makes any sense when the user selects "single selection" for a control since it is effectively allowing the user to multi-select.

In my opinion, it would be confusing to remove this just for single select controls. I hear what you're saying with respect to "effectively allowing the user to multi-select" - but I don't think about it this way? From the outside perspective, "exists" is still a single selection... It's just a single selection that returns multiple results. I can also imagine a situation where "Exists" is saved into a Dashboard as a default value for a single select control, because it can essentially be used to filter out noise and/or invalid data.

Interested in what @andreadelrio thinks, though :)

morrone commented 4 weeks ago

In my opinion, it would be confusing to remove this just for single select controls.

I did suggest making it an option for dashboard designers rather than a blanket change. So if you find it confusing, you could avoid using that option. If you want to also give multi-select Options lists the option to remove the "Exists", I would have no objection to that.

It just seems less useful since selecting all of the items in the Options lists is still going to be possible. In the multi-select case we would just make it more tedious for the users to do what they might want. Unless maybe multi-select can be set to have a limit on the number of things selected. If the dashboard developer can set a limit (e.g. "select any 5"), then I suppose in that case disabling "Exists" would make sense.

I think that dashboard users are going to find it far more confusing to be presented an "Exists" option at the top of the drop-down that, when selected, turns all of the visualizations in the dashboard into nonsense (perhaps also after churning away for a long time on data that is far too large for the things going on in the dashboard).

andreadelrio commented 3 weeks ago

I can see why Exists as an option can be problematic and confusing though this is the first time we hear this feedback afaik. I think as an alternative to allowing users to disable the option we could consider giving it a special treatment like we do for Include/Exclude toggle which is placed in the footer. If this is something that sounds good, I can look into exploring designs for that.

Image

IanLee1521 commented 3 weeks ago

@andreadelrio - I personally think that would make a lot of sense. Would there also need to be a "Does Not Exist" option then too?

Heenawter commented 3 weeks ago

@IanLee1521 You can already get "Does not exist" by selecting "Exclude" and then "Exists"

Image

That being said, if we change the location of the "Exists" option, we could show this in the UI clearer by literally changing the text of the button when "Exclude" is selected

IanLee1521 commented 3 weeks ago

@Heenawter - yes, sorry, I meant if Andrea changes that options location, we'd still want this functionality to be available.

andreadelrio commented 3 weeks ago

@Heenawter - yes, sorry, I meant if Andrea changes that options location, we'd still want this functionality to be available.

Yes, that would be the plan. We'd need to rethink the UI a bit to accommodate for both Include/Exclude and Exist/(not)Exists in the footer in a clear way.

morrone commented 3 weeks ago

we could consider giving it a special treatment like we do for Include/Exclude toggle which is placed in the footer.

Thanks for the suggestion, but I don't think that this approach really accomplishes the goal of this ticket. I want to give the dashboard designer (the persons with modify access) the ability to hide this from the user (the persons with read-only access) entirely. Moving it from one place to another doesn't really accomplish that.

And now that you point it out, I would like to give the dashboard designer the ability to hide the "Include/Exclude" toggle as well. :)