search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Flaky test] KuiContextMenu › props › panels and initialPanelId › allows you to click the title button to go back to the previous panel #19586

Closed stacey-gammon closed 6 years ago

stacey-gammon commented 6 years ago

Failed on master ci

output:

23:50:12  PASS  src/core_plugins/kibana/public/management/sections/indices/edit_index_pattern/source_filters_table/components/header/__tests__/header.test.js
23:50:12  PASS  src/core_plugins/kibana/public/home/components/tutorial/copy_button.test.js
23:50:12  PASS  src/server/index_patterns/service/lib/errors.test.js
23:50:12  PASS  src/core_plugins/kibana/public/home/components/tutorial/footer.test.js
23:50:12 
23:50:12 Summary of all failing tests
23:50:12  FAIL  packages/kbn-ui-framework/src/components/context_menu/context_menu.test.js
23:50:12   ● KuiContextMenu › props › panels and initialPanelId › allows you to click the title button to go back to the previous panel
23:50:12 
23:50:12     expect(value).toMatchSnapshot()
23:50:12     
23:50:12     Received value does not match stored snapshot 2.
23:50:12     
23:50:12     - Snapshot
23:50:12     + Received
23:50:12     
23:50:12     @@ -1,11 +1,11 @@
23:50:12       <div
23:50:12         class="kuiContextMenu"
23:50:12         style="height: 0px;"
23:50:12       >
23:50:12         <div
23:50:12     -     class="kuiContextMenuPanel kuiContextMenu__panel kuiContextMenuPanel-txOutRight"
23:50:12     +     class="kuiContextMenuPanel kuiContextMenu__panel"
23:50:12           tabindex="0"
23:50:12         >
23:50:12           <button
23:50:12             class="kuiContextMenuPanelTitle"
23:50:12             data-test-subj="contextMenuPanelTitleButton"
23:50:12     @@ -27,78 +27,6 @@
23:50:12             <div>
23:50:12               2
23:50:12             </div>
23:50:12           </div>
23:50:12         </div>
23:50:12     -   <div
23:50:12     -     class="kuiContextMenuPanel kuiContextMenu__panel kuiContextMenuPanel-txInRight"
23:50:12     -     tabindex="0"
23:50:12     -   >
23:50:12     -     <button
23:50:12     -       class="kuiContextMenuPanelTitle"
23:50:12     -       data-test-subj="contextMenuPanelTitleButton"
23:50:12     -     >
23:50:12     -       <span
23:50:12     -         class="kuiContextMenu__itemLayout"
23:50:12     -       >
23:50:12     -         <span
23:50:12     -           class="kuiContextMenu__icon kuiIcon fa-angle-left"
23:50:12     -         />
23:50:12     -         <span
23:50:12     -           class="kuiContextMenu__text"
23:50:12     -         >
23:50:12     -           1
23:50:12     -         </span>
23:50:12     -       </span>
23:50:12     -     </button>
23:50:12     -     <div>
23:50:12     -       <button
23:50:12     -         class="kuiContextMenuItem"
23:50:12     -       >
23:50:12     -         <span
23:50:12     -           class="kuiContextMenu__itemLayout"
23:50:12     -         >
23:50:12     -           <span
23:50:12     -             class="kuiContextMenuItem__text"
23:50:12     -           >
23:50:12     -             2a
23:50:12     -           </span>
23:50:12     -           <span
23:50:12     -             class="kuiContextMenu__arrow kuiIcon fa-angle-right"
23:50:12     -           />
23:50:12     -         </span>
23:50:12     -       </button>
23:50:12     -       <button
23:50:12     -         class="kuiContextMenuItem"
23:50:12     -       >
23:50:12     -         <span
23:50:12     -           class="kuiContextMenu__itemLayout"
23:50:12     -         >
23:50:12     -           <span
23:50:12     -             class="kuiContextMenuItem__text"
23:50:12     -           >
23:50:12     -             2b
23:50:12     -           </span>
23:50:12     -           <span
23:50:12     -             class="kuiContextMenu__arrow kuiIcon fa-angle-right"
23:50:12     -           />
23:50:12     -         </span>
23:50:12     -       </button>
23:50:12     -       <button
23:50:12     -         class="kuiContextMenuItem"
23:50:12     -       >
23:50:12     -         <span
23:50:12     -           class="kuiContextMenu__itemLayout"
23:50:12     -         >
23:50:12     -           <span
23:50:12     -             class="kuiContextMenuItem__text"
23:50:12     -           >
23:50:12     -             2c
23:50:12     -           </span>
23:50:12     -           <span
23:50:12     -             class="kuiContextMenu__arrow kuiIcon fa-angle-right"
23:50:12     -           />
23:50:12     -         </span>
23:50:12     -       </button>
23:50:12     -     </div>
23:50:12     -   </div>
23:50:12       </div>
23:50:12 
23:50:12       111 | 
23:50:12       112 |         expect(takeMountedSnapshot(component))
23:50:12     > 113 |           .toMatchSnapshot();
23:50:12       114 |       });
23:50:12       115 |     });
23:50:12       116 |   });
23:50:12       
23:50:12       at Object.it (packages/kbn-ui-framework/src/components/context_menu/context_menu.test.js:113:12)
23:50:12 
23:50:12 
23:50:12 Snapshot Summary
23:50:12  › 1 snapshot test failed in 1 test suite. Inspect your code changes or re-run jest with `-u` to update them.
23:50:12

Link: https://kibana-ci.elastic.co/job/elastic+kibana+master+multijob-intake/654/console

Never saw it fail before so perhaps only very rarely flaky but wanted to file so the team was aware in case anyone else saw it pop up too!

cc @elastic/kibana-design

nreese commented 6 years ago

KuiContextMenu is no longer used in kibana. Maybe we should prune parts of the KUI framework that are no longer needed?

stacey-gammon commented 6 years ago

Makes a lot of sense to me, will avoid more people from starting to use them, then we can close this out.

snide commented 6 years ago

That's the plan... See... https://github.com/elastic/kibana/pull/20995

cjcenizal commented 6 years ago

@Stacey-Gammon Can we close this issue now? There's a deprecation notice on the KUI docs, so I don't think anyone is going to reintroduce KuiContextMenu into Kibana and since KuiContextMenu is no longer used in Kibana, this issue doesn't apply any more.

For reference, https://github.com/elastic/kibana/issues/15529 provides a guide on how to convert KUI React code to EUI. At some point we should create an issue to track this conversion process (different from Dave's PR which is about converting LESS to Sass).

stacey-gammon commented 6 years ago

sgtm, don't recall seeing this as a flaky failure in a long time anyway. We can always re-open if we do!