search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.23k forks source link

[Security Solution] Unskip tests for preventing non-customizable fields from updating for Prebuilt rule types #195921

Open banderror opened 1 month ago

banderror commented 1 month ago

Related to: https://github.com/elastic/kibana/pull/195318, https://github.com/elastic/kibana/pull/195926

Summary

Tests added in https://github.com/elastic/kibana/pull/195318 failed in the periodic pipeline (build) and were skipped in https://github.com/elastic/kibana/pull/195926.

That failure happened in installPrebuiltRules -> refreshSavedObjectIndices.

Saved objects refresh doesn't work in serverless pipelines, such as the 2nd quality gate and the periodic pipeline. We added it in this PR to reduce flakiness. However, we might not need it anymore since @maximpn added a refresh: 'wait_for' to the Fleet's package installation code in this PR.

Let's try to unskip these tests to keep them enabled in the 2nd quality gate.

elasticmachine commented 1 month ago

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine commented 1 month ago

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

elasticmachine commented 1 month ago

Pinging @elastic/security-detections-response (Team:Detections and Resp)

dplumlee commented 3 weeks ago

Note: when this PR gets merged, we won't need to unskip the bulk route tests in 9.0 as the files will be skipped permanently or deleted. We will still have to unskip and backport to 8.x