search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.8k stars 8.19k forks source link

[Fleet]: Pre-released version should not be installed when Display beta integrations toggle is disabled and never enabled. #196050

Open amolnater-qasource opened 4 days ago

amolnater-qasource commented 4 days ago

Kibana Build details:

VERSION: 8.16.0-SNAPSHOT
BUILD: 79128
COMMIT: d7556c5782195e1a8526c4b52a976597e32ba242

Preconditions:

  1. 8.16.0-SNAPSHOT Kibana cloud environment with Security Solution should be available.

Steps to reproduce:

  1. Navigate to Fresh 8.16.0-SNAPSHOT.
  2. Observe 8.16.0-prerelease.1 is pre-installed even when Display beta integrations toggle is disabled and never enabled.

Expected Result: Pre-released version should not be installed when Display beta integrations toggle is disabled and never enabled.

Screen Recording:

https://github.com/user-attachments/assets/ea7fa75f-3b99-43bb-934c-b66ab0b06ef9

elasticmachine commented 4 days ago

Pinging @elastic/fleet (Team:Fleet)

amolnater-qasource commented 4 days ago

@muskangulati-qasource Please review.

muskangulati-qasource commented 4 days ago

Secondary review is Done for this ticket!

kpollich commented 3 hours ago

Hmm this is a bit unexpected, I think, as the bundled version of endpoint should be 8.15.1 per

https://github.com/elastic/kibana/blob/744fe6493761f9d0eb0d69969d638a6354b41641/fleet_packages.json#L37

There might be a bug with the auto upgrade logic for endpoint that's causing the package to immediately upgrade to a prerelease version after Fleet setup runs?

@nchaulet - Would you be able to take a look at this to help triage?

nchaulet commented 2 hours ago

It seems it the expected behaviour for the security solution package they install prerelease package for main or -SNAPSHOT

See related code: https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/install_prebuilt_rules_and_timelines/install_prebuilt_rules_package.ts#L55-L59 https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/server/lib/detection_engine/prebuilt_rules/api/install_prebuilt_rules_and_timelines/install_prebuilt_rules_package.ts#L32

@elastic/security-defend-workflows FYI to check this is not a bug