search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.64k stars 8.23k forks source link

[Dashboard][Usability] Allow users to scroll for inline editing of Lens visualizations #196203

Open rshen91 opened 1 month ago

rshen91 commented 1 month ago

References: https://github.com/elastic/kibana/pull/188236 https://github.com/elastic/kibana/pull/193430

In the above PR, scrolling was disabled to solve the issue of This PR adds a side effect to opening the inline config editor to disable scroll on the document body, this way the user's scroll interaction if any remains within the open inline lens config editor, whilst keeping on the panel whose configuration is being modified in focus.

I think we might want to discuss this decision: Lens visualizations that are greater than the viewport height are then locked and then the user cannot see the full visualization

Image

elasticmachine commented 1 month ago

Pinging @elastic/kibana-presentation (Team:Presentation)

elasticmachine commented 1 month ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Heenawter commented 1 month ago

See https://github.com/elastic/kibana/issues/185895 for why this scrolling was disabled in the first place :) I don't think it's correct to simply add this scrolling back without addressing the concerns that removing the scrollbar was trying to fix.