search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.81k stars 8.2k forks source link

[Field Formats] Duration formatter should handle pluralization for single values #196761

Open nickofthyme opened 2 days ago

nickofthyme commented 2 days ago

Describe the feature:

The Friendly duration formatters should account for singular values. Currently, we only use pluralized formats.

This is where we compute the unit text and join it with the value...

https://github.com/elastic/kibana/blob/89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb/src/plugins/field_formats/common/converters/duration.ts#L134-L137

Here is the list of all values...

https://github.com/elastic/kibana/blob/89d833bf58ba614a0e9eb6a38a02c4eb5a641aeb/src/plugins/field_formats/common/constants/duration_formats.ts#L18-L167

This only applies to the long form text strings and not the shortText strings.

Describe a specific use case for the feature:

Image

Notice 1 seconds should be 1 second.

Pretty simple and low impact but could be nice.

elasticmachine commented 1 day ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)