elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.82k stars 8.21k forks source link

[ES|QL] Add MATCH function in autocomplete and fix the UX with field statistics #196995

Open stratoula opened 5 days ago

stratoula commented 5 days ago

Describe the feature:

The MATCH function has been added on technical preview in autocomplete.

FROM kibana_sample_data_logs |  WHERE MATCH(geo.dest, "CN")

The MATCH function works under specific circumstances. For example it doesn't work after a limit.

We need to:

This gist contains some examples. The current limitations are:

elasticmachine commented 5 days ago

Pinging @elastic/kibana-esql (Team:ESQL)

stratoula commented 5 days ago

Also I had to silence the autocomplete match tests, we need to enable them when autocomplete works as expected. https://github.com/elastic/kibana/pull/196993

stratoula commented 5 days ago

I think I have fixed all client side validation bugs in this PR https://github.com/elastic/kibana/pull/196992

stratoula commented 4 days ago

So the stats logic should change to not add the limit after from.... ONLY when at least a match, qstr function exists. In these cases and only add it after the last where match / qstr command.

The apis from Vadim can hopefully help with this.

stratoula commented 4 days ago

ES team will try to raise the limit limitation, in tht cases we won't need to do anything for the stats. Waiting for ES team to investigate. I am blocking it for now.

ES issue: https://github.com/elastic/elasticsearch/issues/115297

serenachou commented 4 days ago

cc @aznick