Open stratoula opened 5 days ago
Pinging @elastic/kibana-esql (Team:ESQL)
Also I had to silence the autocomplete match tests, we need to enable them when autocomplete works as expected. https://github.com/elastic/kibana/pull/196993
I think I have fixed all client side validation bugs in this PR https://github.com/elastic/kibana/pull/196992
So the stats logic should change to not add the limit after from....
ONLY when at least a match, qstr function exists. In these cases and only add it after the last where match / qstr command.
The apis from Vadim can hopefully help with this.
ES team will try to raise the limit limitation, in tht cases we won't need to do anything for the stats. Waiting for ES team to investigate. I am blocking it for now.
ES issue: https://github.com/elastic/elasticsearch/issues/115297
cc @aznick
Describe the feature:
The MATCH function has been added on technical preview in autocomplete.
The MATCH function works under specific circumstances. For example it doesn't work after a limit.
We need to:
This gist contains some examples. The current limitations are:
match() and qstr() can only be used in WHERE commands
The field parameter can only be an ES index field
match() or qstr() can't be used as part of a disjunction
match() can't be used after LIMIT.
qstr() can't be used after SHOW, ROW, DISSECT, ENRICH, EVAL, GROK, KEEP, MV_EXPAND, RENAME, STATS or LIMIT.
the fields statistics fail when the match operator is used. This happens because we always append a limit after the from command and the limit and where match are not compatible. I think that for now we need to disable the field statistics when match is detected (I will discuss with ES search team too). Blocked by https://github.com/elastic/elasticsearch/issues/115297
also field statistics tab fail significantly Blocked by https://github.com/elastic/elasticsearch/issues/115297