[Timelion] Add deprecation badge

elastic / kibana

Your window into the Elastic Stack

https://www.elastic.co/products/kibana

Other

19.69k stars 8.24k forks source link

[Timelion] Add deprecation badge #197176

Open markov00 opened 1 month ago

markov00 commented 1 month ago

The Timelion App was deprecated in 7.10 and the standalone app was removed in 7.16. The app was removed and a Timelion visualization type was created instead, providing just a simplified textual experience.

We are now looking to deprecate completely Timelion and remove it from Kibana within the next ~2-year timespan.

The reasons for deprecating timelion are:

reduce fragmentation around the capabilities provided by each visualization editor
focus all the efforts toward Lens as the main and only visualization editor available in Kibana, by reaching feature parity with all other existing editor and beyond.
reduce code complexity, tech debt, CI testing time, and bundle size

The task for now is only to add a deprecation badge to the Timelion icon when creating an Agg Based Visualization

elasticmachine commented 1 month ago

Pinging @elastic/kibana-visualizations (Team:Visualizations)

mbondyra commented 1 month ago

The task for now is only to add a deprecation badge to the Timelion icon when creating an Agg Based Visualization

I don't think we have the deprecation badge as something already designed, do we? Do we need a little mockup here? CC @MichaelMarcialis

MichaelMarcialis commented 1 month ago

We already have Timeline (as well as all other "aggregation-based" visualizations) housed under the "Legacy" tab in the visualization creation modal. This tab is accompanied by a tooltip that explains those visualizations are scheduled for deprecation. Do we need an additional deprecation badge specifically on the Timelion option? If so, why only for Timelion? Alternatively, should we change the "Legacy" tab to "Deprecated" to avoid fragmenting terminology for our users? Or is Timelion really the only one that that is actually officially deprecated?

Also, this request sounds like we only wish to add a badge during the creation flow. Should we also be informing users within the actual editor (whether new or existing)? If so, what terminology should we use (legacy or deprecated)?

CCing @teresaalvarezsoler.

teresaalvarezsoler commented 1 month ago

I never shared the idea that Timelion needs a different treatment than the rest of Agg based visualizations. I know it's a separate animal in our code base but it's confusing for users that may see it as part of Agg based visualizations. I never understood the benefits of this deprecation badge in isolation and why we cannot wait to do it as part of the Agg based visualizations @markov00

markov00 commented 3 weeks ago

This was just one of the many items that followed the request to break changes in 9.0. I will revisit all these this week and upgrade these issues. For now please don't consider this as a task.