search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.6k stars 8.21k forks source link

[Management] Number fields accept invalid input #197506

Open ElenaStoeva opened 1 week ago

ElenaStoeva commented 1 week ago

While testing https://github.com/elastic/kibana/pull/196527, I noticed that different form fields in Kibana Management plugins accept invalid input in number fields. Examples I noticed:

https://github.com/user-attachments/assets/6a883a7b-0cf4-43e2-bc36-c0ff6d2ebf1b

https://github.com/user-attachments/assets/45e21ff4-fc0d-4ef0-89c9-4dc922e1abfe

I think the e, -, and , characters are allowed by the Eui number field itself and it contains some validation for valid numbers. We should probably add validations from our side for valid numbers as well and not allow submitting the form if the number is invalid.

elasticmachine commented 1 week ago

Pinging @elastic/kibana-management (Team:Kibana Management)