search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

[Security Solution] Enable draggable headers in Timeline Unified Data table. #198955

Open logeekal opened 1 week ago

logeekal commented 1 week ago

Summary

Recently EUIDataGrid and UnifiedDataTable implemented the capability to enable reordering of columns by dragging them. See https://github.com/elastic/kibana/pull/197832.

As per discussion here, when draggability of headers is enabled, All of the columns header operations such as Move left, Remove column, Copy Column stop working.

Image

We need to see why this is happening since it is standard EUI feature. If there are changes needed in Security solution to make it compatible, it should be looked into.

elasticmachine commented 1 week ago

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

davismcphee commented 1 week ago

@logeekal I looked into this a bit more and it seems at least part of this (the actions menu) is actually a bug in EUI when EuiDataGrid is rendered within EuiModal. I created an issue for it here: https://github.com/elastic/eui/issues/8119.

I wasn't able to reproduce the issue where dragging the headers doesn't work at all directly in EUI, but it's possible these issues still might be related.

logeekal commented 1 week ago

Thank you @davismcphee. this is a great find. We also have Timeline Integration tests which run as e2e test just for timeline component and does not render Timeline in a modal and all tests pass there.

https://github.com/elastic/kibana/blob/14a1a92a422fa7fc69902e5a80d071b182dc37aa/x-pack/plugins/security_solution/public/timelines/components/timeline/tabs/query/index.test.tsx#L431-L436