search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.61k stars 8.22k forks source link

[React@18] Post-upgrade `@testing-library/react` clean up #199100

Open Dosant opened 1 day ago

Dosant commented 1 day ago

As part of upgrade to React@18 we've upgraded @testing-library/react and introduced some workarounds for it to run with React@17 https://github.com/elastic/kibana/pull/198918

I am creating this issue to track the removal of those workarounds once we upgrade the runtime to React@18 and start transitioning to the Concurent Mode. 

- [ ] Clean `react-dom/client` introduced in https://github.com/elastic/kibana/pull/198918#issue-2635210946
- [ ] Come up with a migration path from `legacyRoot:true` in testing-library introduced in https://github.com/elastic/kibana/pull/198918#issue-2635210946 as part of the transition to Concurrent Mode
- [ ] Clean console override to mute some of act warning
elasticmachine commented 1 day ago

Pinging @elastic/appex-sharedux (Team:SharedUX)