search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

Make Help dropdown consistent across all environments #199465

Open ek-so opened 1 week ago

ek-so commented 1 week ago

Problem

Currently, we have inconsistently used components for Help dropdown across Kibana on Cloud and inside deployment/project. Image (created based on this issue after Serverless bug bash initiative)

Solution

The intent is to:

  1. Use euiContextMenu component consistently in all those cases, so that all menus look like the one that is currently on Cloud
  2. Remove Search icon from the dropdown entirely (based on this discussion)
  3. Add external link icons to all the external links consistently
ek-so commented 1 week ago

I was wondering if we should also add "external" arrows to all links that imply opening another urls. But form the other hand, we could also remove them all entirely from the menu, because they all indicate actions which sort of suggest leaving (and losing) current context for the user, even if they don't necessarily imply opening external page.

@jovana-andjelkovic @simosilvestri curious what are your thoughts on it?

jovana-andjelkovic commented 1 week ago

@ek-so I would keep the external link icons for the sake of accessibility. Not sure if the suggestion was to remove icons or links in dropdown? 😅

ek-so commented 1 week ago

@ek-so I would keep the external link icons for the sake of accessibility. Not sure if the suggestion was to remove icons or links in dropdown? 😅

Thanks Jovana! Suggestion is to use context menu component, which means it'll be black menu items like on Cloud.

The question was about external (arrow) icons. So I assume your answer is too keep them (and then, add to other places in those menus where we don't always have them, like for example in Serverless — Support, Give fb are external links).

jovana-andjelkovic commented 6 days ago

@ek-so yeah that makes sense to me!

elasticmachine commented 6 days ago

Pinging @elastic/appex-sharedux (Team:SharedUX)

ek-so commented 6 days ago

Hi @petrklapka, could you pls take a look and say whether it's ours :) Related to navigation, that's why I thought we might pick it up.

tsullivan commented 1 hour ago

Hi @petrklapka, could you pls take a look and say whether it's ours :) Related to navigation, that's why I thought we might pick it up.

The piece about removing the search icon (Elasticsearch product icon) is something we can assist with. The other parts of this issue are indeed ours.