elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.68k stars 8.23k forks source link

`React does not recognize the `isCollapsible` prop on a DOM element` error #200219

Open PhilippeOberti opened 2 weeks ago

PhilippeOberti commented 2 weeks ago

Describe the bug The error appears in the console React does not recognize theisCollapsibleprop on a DOM element.

Impact and severity No user impact and probably very low priority, though should be a straightforward error the fix.

Environment and versions

To Reproduce Steps to reproduce the behavior:

  1. Enable the space-specific Security navigation (Manage spaces => Default => Select solution view => Security)
  2. Navigate to any page with the Security Solution application

Changing the navigation back to Classic makes the error go away.

Expected behavior The console error should not be thrown.

Screenshots Image

Additional context I tried looking at some of the EUI components that could have been at fault here:

cee-chen commented 2 weeks ago

Likely an issue with EuiCollapsibleNavBeta if switching to Classic fixes the problem. May also be an issue with Kibana's implementation of EuiCollapsibleNavBeta

cee-chen commented 2 weeks ago

After taking a closer look, this is almost certainly an issue in Kibana itself / with the Shared UX implementation of serverless nav, not in the underlying EUI components. Can you transfer this issue to the Kibana repo? cc @sebelga @tsullivan

From what I can tell from the the stacktrace posted, it indicates that an isCollapsible key is getting passed to the accordionProps object which means it needs to be extracted from accordionProps before the rest of the spread is passed down to the component.

That issue is likely here: https://github.com/elastic/kibana/blob/a3289e440ad88825b1ae17495caf13ef5720ae7c/packages/shared-ux/chrome/navigation/src/ui/hooks/use_accordion_state.ts#L110

sebelga commented 1 week ago

I'll look into it 👍

elasticmachine commented 1 week ago

Pinging @elastic/appex-sharedux (Team:SharedUX)