elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[Discover][UnifiedHistogram] Remove exception preventing code when rendering the chart #200986

Open kertal opened 1 day ago

kertal commented 1 day ago

In #200687 we added code, to prevent flakiness when the UnifiedHistogram was being rendered in Discover. It was clearly reproduceable, that the following action led to an exception when rendering the UnifiedHistogram which is using the Lens Embeddable.

The code added in #200687 was safeguarding the given exception, which appeared to be the most reliable of multiple approaches. But it didn't target the root cause, which appears to be a race condition in the way the required properties were passed in the component.

However it should be removed once possible, which could be done after a refactoring of the UnifiedHistogram or even when #186642 was merged (which refactors large parts of the code)

elasticmachine commented 1 day ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)