elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[ML] Trained Models: fix `NaN` in a progress bar during the download task initialization #201221

Closed darnautov closed 31 minutes ago

darnautov commented 19 hours ago

Summary

When we request a status of the download task right after initializing a download, total_parts might be returned with a 0 value, hence dividing by 0 for the progress bar causing in NaN% value rendered. This PR adds a fallback to -1 for that, to make sure we render 0%.

Checklist

elasticmachine commented 19 hours ago

Pinging @elastic/ml-ui (:ml)

elasticmachine commented 17 hours ago

:green_heart: Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.7MB 4.7MB +6.0B

cc @darnautov

kibanamachine commented 31 minutes ago

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/11970833950

kibanamachine commented 26 minutes ago

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation