search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[Security Solution] Adds callback onChangePage to get current page Index in Unified Data table #201240

Open logeekal opened 18 hours ago

logeekal commented 18 hours ago

Summary

elasticmachine commented 18 hours ago
:robot: Jobs for this PR can be triggered through checkboxes. :construction: :information_source: To trigger the CI, please tick the checkbox below :point_down: - [ ] Click to trigger **kibana-pull-request** for this PR! - [ ] Click to trigger **kibana-deploy-project-from-pr** for this PR!
logeekal commented 1 hour ago

hey @logeekal at first glance everything worked perfectly, but doing a little more testing I noticed that as soon as we navigate to the last page and click on Load more, then everything is completely messed up:

the events per page returned by the new callback don't match the events rendered in the UI the callback isn't being triggered at all for all the newly loaded pages

I knew you will find something 👨‍🎤 .. it looks like this is something which already exists.

Raised a bug for that here : https://github.com/elastic/kibana/issues/201330

Will try to see if we can fix it in this PR itself. I think it is a small fix.