elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[Discover] Remove the legacy table #201254

Open jughosta opened 3 days ago

jughosta commented 3 days ago

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

elasticmachine commented 3 days ago
:robot: Jobs for this PR can be triggered through checkboxes. :construction: :information_source: To trigger the CI, please tick the checkbox below :point_down: - [ ] Click to trigger **kibana-pull-request** for this PR! - [ ] Click to trigger **kibana-deploy-project-from-pr** for this PR!
github-actions[bot] commented 3 days ago

A documentation preview will be available soon.

Request a new doc build by commenting * Rebuild this PR: `run docs-build` * Rebuild this PR and all Elastic docs: `run docs-build rebuild` `run docs-build` is much faster than `run docs-build rebuild`. A `rebuild` should only be needed in rare situations. If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status [here](https://buildkite.com/elastic/docs-build).
elasticmachine commented 2 days ago

:green_heart: Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 980 969 -11
unifiedDocViewer 225 217 -8
total -19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 810.1KB 804.0KB -6.2KB
unifiedDocViewer 126.0KB 115.8KB -10.3KB
total -16.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 51.1KB 51.0KB -56.0B
unifiedDocViewer 12.3KB 11.8KB -482.0B
total -538.0B
Unknown metric groups #### async chunk count | id | [before](https://github.com/elastic/kibana/commit/e378c884cd476c13cba86794127cca8e68c390cb) | [after](https://github.com/elastic/kibana/commit/b5dc7aa5aa31bfc4c14ce1a1895bbd7ef38c982b) | diff | | --- | --- | --- | --- | | `unifiedDocViewer` | 10 | 8 | -2 | #### ESLint disabled line counts | id | [before](https://github.com/elastic/kibana/commit/e378c884cd476c13cba86794127cca8e68c390cb) | [after](https://github.com/elastic/kibana/commit/b5dc7aa5aa31bfc4c14ce1a1895bbd7ef38c982b) | diff | | --- | --- | --- | --- | | `unifiedDocViewer` | 9 | 8 | -1 | #### Total ESLint disabled count | id | [before](https://github.com/elastic/kibana/commit/e378c884cd476c13cba86794127cca8e68c390cb) | [after](https://github.com/elastic/kibana/commit/b5dc7aa5aa31bfc4c14ce1a1895bbd7ef38c982b) | diff | | --- | --- | --- | --- | | `unifiedDocViewer` | 9 | 8 | -1 |

History

cc @jughosta