elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

[Fleet] Fix agent dashboard link accross multiple space #201280

Open nchaulet opened 8 hours ago

nchaulet commented 8 hours ago

Summary

Resolve https://github.com/elastic/kibana/issues/193664

Fix agent dashboard link when the integration is installed in multiple space, we now can install kibana assets in multiple space, but the dashboard link was using the hardcoded id of the dashboard, when installing in a new space the dashboard id is different that PR fix that by using the correct dashboard id when available.

Test

How to test? with space awareness enabled (feature flag + api call)

Create multiple space and add agent to those space

Check the dashboard link is visible and working when kibana assets are installed in the space

Screenshot 2024-11-21 at 3 16 18 PM Screenshot 2024-11-21 at 2 26 16 PM Screenshot 2024-11-21 at 3 17 25 PM Screenshot 2024-11-21 at 3 19 10 PM
elasticmachine commented 8 hours ago

Pinging @elastic/fleet (Team:Fleet)

elasticmachine commented 6 hours ago

:broken_heart: Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 1240 1241 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +773.0B

History

cc @nchaulet