force version non conflict diff when base version is missing

[maximpn]

Resolves: https://github.com/elastic/kibana/issues/200904

Summary

This PR unlocks Prebuilt Rules Customization workflow for rules with missing base version.

Details

Each Prebuilt Rule update contains version diff. version is a special non-customizable field we use to track prebuilt rule version. It always gets target rule version's value after rule upgrade.

A generic numberDiffAlgorithm algorithm was used for version field. It produces a SOLVABLE conflict when rule's base version is missing. It blocked the workflow in UI. We check the number of field with conflicts versus resolved conflicts to decide when a rule is ready for upgrade. In case version field got a conflict user had no possibility to resolve it.

The fix adds a new forceTargetVersionDiffAlgorithm diff algorithm applied only for version field. It produces a non-conflict diff all the time even when base version is missing. The reason behind is that version always gets target rule's version.

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

[elasticmachine]

:broken_heart: Build Failed

• Buildkite Build
• Commit: 0c5eff1a1ef6d12a05c13d8c036ba0a5f74b208c

Failed CI Steps

• Jest Tests #18
• Jest Tests #18
• FTR Configs #35
• FTR Configs #35
• FTR Configs #44
• FTR Configs #44
• FTR Configs #51
• FTR Configs #51
• FTR Configs #97
• FTR Configs #97

Test Failures

• [job] [logs] Jest Tests #18 / calculateRuleSource returns an external rule source with customized false when the rule is prebuilt
• [job] [logs] Jest Tests #18 / calculateRuleSource returns an external rule source with customized false when the rule is prebuilt
• [job] [logs] Jest Tests #18 / calculateRuleSource returns is_customized false when the rule has only changes to revision, updated_at, updated_by
• [job] [logs] Jest Tests #18 / calculateRuleSource returns is_customized false when the rule has only changes to revision, updated_at, updated_by
• [job] [logs] Jest Tests #18 / calculateRuleSourceForImport calculates as external without customizations if an exact match is found
• [job] [logs] Jest Tests #18 / calculateRuleSourceForImport calculates as external without customizations if an exact match is found
• [job] [logs] Jest Tests #18 / calculateRuleSourceFromAsset matching rule_id and version is found calculates as customized external type if the imported rule has all fields unchanged from the asset
• [job] [logs] Jest Tests #18 / calculateRuleSourceFromAsset matching rule_id and version is found calculates as customized external type if the imported rule has all fields unchanged from the asset
• [job] [logs] FTR Configs #44 / Rules Management - Prebuilt Rules - Prebuilt Rule Customization @ess @serverless @skipInServerlessMKI is_customized calculation prebuilt rules should set is_customized to false if the change has been reverted
• [job] [logs] FTR Configs #51 / Rules Management - Prebuilt Rules - Prebuilt Rule Customization @ess @serverless @skipInServerlessMKI is_customized calculation prebuilt rules should set is_customized to false if the change has been reverted
• [job] [logs] FTR Configs #44 / Rules Management - Prebuilt Rules - Prebuilt Rule Customization @ess @serverless @skipInServerlessMKI is_customized calculation prebuilt rules should set is_customized to false if the change has been reverted
• [job] [logs] FTR Configs #51 / Rules Management - Prebuilt Rules - Prebuilt Rule Customization @ess @serverless @skipInServerlessMKI is_customized calculation prebuilt rules should set is_customized to false if the change has been reverted
• [job] [logs] FTR Configs #35 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI review prebuilt rules updates from package with mock rule assets rule type fields when rule base version does not exist when rule field has an update and a custom value that are the same - scenario -AA should not show in the upgrade/_review API response
• [job] [logs] FTR Configs #97 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI review prebuilt rules updates from package with mock rule assets rule type fields when rule base version does not exist when rule field has an update and a custom value that are the same - scenario -AA should not show in the upgrade/_review API response
• [job] [logs] FTR Configs #97 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI review prebuilt rules updates from package with mock rule assets rule type fields when rule base version does not exist when rule field has an update and a custom value that are the same - scenario -AA should not show in the upgrade/_review API response
• [job] [logs] FTR Configs #35 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI review prebuilt rules updates from package with mock rule assets rule type fields when rule base version does not exist when rule field has an update and a custom value that are the same - scenario -AA should not show in the upgrade/_review API response

Metrics [docs]

✅ unchanged

History

cc @maximpn