elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.68k stars 8.23k forks source link

[A11y] Fix space button clearing the index name input #201349

Closed jedrazb closed 3 days ago

jedrazb commented 3 days ago

Summary

Let's just disallow space input as index names can't contain spaces anyway. This fixes an a11y issue raised recently.

Fix (im clicking space a lot in the vid):

https://github.com/user-attachments/assets/bdf3217a-2869-4814-8243-900c348e24fb

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

elasticmachine commented 3 days ago

:yellow_heart: Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +47.0B
kibanamachine commented 3 days ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11974013214

kibanamachine commented 3 days ago

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation