elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.68k stars 8.23k forks source link

[Discover][Alerts] fix: add mobile width and fix title row wrap #201354

Closed akowalska622 closed 3 days ago

akowalska622 commented 3 days ago

Summary

Closes #200162

Long data view names weren't truncated on mobile view. Also noticed the "X" icon to go on the second row - fixed it within the same PR.

Before: image

After:

Screenshot 2024-11-22 at 11 55 47

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

akowalska622 commented 3 days ago

I followed the current css pattern (inline style), but this code seems to be 3 y.o. old. Should we migrate to emotions?

elasticmachine commented 3 days ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine commented 3 days ago

:green_heart: Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackAlerts 25.1KB 25.2KB +66.0B

cc @akowalska622

jughosta commented 3 days ago

I followed the current css pattern (inline style), but this code seems to be 3 y.o. old. Should we migrate to emotions?

Yes, that would be great! Emotion is what we use nowadays.

akowalska622 commented 3 days ago

@jughosta refactored to emotions, PR ready :)

kibanamachine commented 3 days ago

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11979974852

kibanamachine commented 3 days ago

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation