Closed akowalska622 closed 3 days ago
I followed the current css pattern (inline style
), but this code seems to be 3 y.o. old. Should we migrate to emotions?
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)
Size of the bundles that are downloaded on every page load. Target size is below 100kb
id | before | after | diff |
---|---|---|---|
stackAlerts |
25.1KB | 25.2KB | +66.0B |
cc @akowalska622
I followed the current css pattern (inline style), but this code seems to be 3 y.o. old. Should we migrate to emotions?
Yes, that would be great! Emotion is what we use nowadays.
@jughosta refactored to emotions, PR ready :)
Starting backport for target branches: 8.x
Status | Branch | Result |
---|---|---|
✅ | 8.x |
Note: Successful backport PRs will be merged automatically after passing CI.
Please refer to the Backport tool documentation
Summary
Closes #200162
Long data view names weren't truncated on mobile view. Also noticed the "X" icon to go on the second row - fixed it within the same PR.
Before:
After:
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.