elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.78k stars 8.19k forks source link

verifyTranslations fails due to Unknown config key: elasticsearch.tribe.url #21981

Closed tylersmalley closed 6 years ago

tylersmalley commented 6 years ago

The 6.x branch is currently failing with the following:

https://kibana-ci.elastic.co/job/elastic+kibana+6.x+multijob-intake/3/console

23:38:25 Running "verifyTranslations" task
23:38:29 Warning: Unknown config key: elasticsearch.tribe.url Use --force to continue.
23:38:29 

Appears to have started with: bb97a53a3f06e4905591f082679e9f665787f226 from https://github.com/elastic/kibana/pull/21093

tylersmalley commented 6 years ago

@archanid can you look into this?

rhoboat commented 6 years ago

this failure on 6.x saved us. the same problem actually exists in the master branch, but we swallow the actual error. the reason we see a failure in 6.x is because tribe node is still supported, and the console app config has to check whether that setting in elasticsearch.tribe is configured. this check throws an error, so we finally see there's a problem. but the underlying error has nothing to do with tribe node. (we don’t see any errors in master because tribe setting was removed, so the console app no longer needs to check the elasticsearch.tribe setting, and nothing else throws an error even after the swallowed error.)

the underlying error is "unable to compile typescript". the elasticsearch plugin config isn’t getting parsed because it’s now using the mappings lib which is in typescript, and it for some reason throws this error. I don’t know how to solve this typescript parsing/compiling problem, so i've created a PR to revert this change for now.

tylersmalley commented 6 years ago

Good find. @spalger, do you have any ideas on how to resolve this issue?

Additionally, I am unable to provide tribe setting at runtime:

 ~/e/kibana   6.x   node scripts/kibana --elasticsearch.tribe.url=http://localhost:9200
(node:83179) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
WARNING: screenSmall() has been deprecated. Please use euiBreakpoint('m') instead.
         on line 72 of node_modules/@elastic/eui/src/global_styling/mixins/_responsive.scss, in mixin `screenSmall`
         from line 94 of x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/views/_pipeline_viewer.scss
         from line 1 of x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/views/_index.scss
         from line 21 of x-pack/plugins/monitoring/public/index.scss

  log   [14:08:44.006] [info][scss] Compiled CSS: /Users/tyler/elastic/kibana/src/core_plugins/status_page/public/index.scss
  log   [14:08:44.009] [info][scss] Compiled CSS: /Users/tyler/elastic/kibana/x-pack/plugins/monitoring/public/index.scss
  log   [14:08:44.009] [info][scss] Compiled CSS: /Users/tyler/elastic/kibana/src/core_plugins/kibana/public/index.scss
 error  [14:08:44.014] [fatal] Error: Unmet requirement "console" for plugin "console_extensions"
    at callPluginHook (/Users/tyler/elastic/kibana/src/server/plugins/lib/call_plugin_hook.js:28:13)
    at callPluginHook (/Users/tyler/elastic/kibana/src/server/plugins/lib/call_plugin_hook.js:45:11)
    at <anonymous>
FATAL Error: Unmet requirement "console" for plugin "console_extensions"
    at callPluginHook (/Users/tyler/elastic/kibana/src/server/plugins/lib/call_plugin_hook.js:28:13)
    at callPluginHook (/Users/tyler/elastic/kibana/src/server/plugins/lib/call_plugin_hook.js:45:11)
    at <anonymous>

Is this due to the same underlying issue?

rhoboat commented 6 years ago

@tylersmalley can you try it again using my revert branch on 6.x? https://github.com/elastic/kibana/pull/22004

rhoboat commented 6 years ago

I'm seeing the issue on the reverted branch as well. It might be a regression.

tylersmalley commented 6 years ago

Yeah, checking it out now.

rhoboat commented 6 years ago

I did some digging and, yes, passing in the elasticsearch.tribe.url arg fails silently in plugin_discovery find_plugin_specs. the console plugin doesn't get added.