elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.71k stars 8.12k forks source link

Structure code between InfraOps and SecOps #24035

Closed XavierM closed 5 years ago

XavierM commented 5 years ago

In EAH, we decide that will work in the same folder. To re-open the discussion and finalyze the answer, I am creating an issue, se we can discuss how we would like our code to be structure so we can work together without walking on each other toes. Please advice or offer your own, so we can start our secops app ;)

That's how the code is structure as today:

skh commented 5 years ago
XavierM commented 5 years ago

Also, for the server side, I did not want to create a substructure because I wanted to be more like a generic API and not guided by infra_ops or sec_ops but more by the needs of metrics/networks/hosts/ etc Does that make sense?

weltenwort commented 5 years ago

I agree with what @skh said, but looks reasonable on general. If/how we reflect the structure in the store(s) needs some more thought on my side before I can voice an opinion.

XavierM commented 5 years ago

@weltenwort maybe, for now, we do not need to have a common store and we will see if we get a feature later on where we need a common a store between our two applications.

I was more thinking to do something like that https://redux.js.org/recipes/isolatingsubapps for now and see how it goes.

weltenwort commented 5 years ago

yes, not much risk in going that route first. if you intend to go with redux at all - have you already settled on that?

tsg commented 5 years ago

I think we can close this one, right? Reopen if you left it open intentionally.