Closed jen-huang closed 5 months ago
Pinging @elastic/kibana-app
Pinging @elastic/es-ui
Note that when we make this change we'll also have to update the Rollup API integration tests so that they use rollup job payloads that mirror those produced by the UI.
Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.
Describe the feature:
Support changes in https://github.com/elastic/elasticsearch/pull/33727, specifically for rollups.
ES UI tasks
calendar
orfixed
for their date histogram configuration.calendar
.1h
would have previously been treated as a calendar unit, so ask the user if they want to treat it as a calendar or fixed interval, and write it tocalendar_interval
orfixed_interval
based on their choice.2h
is always treated as a fixed interval, so do not offer user the choice between units and just write it tofixed_interval
.Examples of resulting rollup job date histogram configurations:
Calendar:
Fixed:
Coerced (user didn't specify an interval type, so
1h
is treated as calendar). We should continue supporting this for BWC, but new rollup jobs created with the revised Rollup Jobs Wizard should not have this format:Kibana App tasks
calendar_interval
orfixed_interval
in date histo aggs has the same information written to itstypeMeta
fieldcalendar_interval
,fixed_interval
, orinterval
. Some relevant files:fixed_interval: "1h"
and user inputs1d
, sendfixed_interval: "1d"
to the rollup search endpoint (instead ofinterval: "1d"
).interval: "1d"
in this case) should work, but we should think about what the user is going to want/expect when they query rollup docs.