The compressed EUI form inputs have been redesigned which has resulted in some small visual design 'breaks' and new opportunities to improve our form layouts.
Since each element has its own sidebar, let's attempt to divide the work up by element (listed below). There are two steps to cleaning up each Canvas element:
1) follow The checklist from the Meta cleanup issue (copy/paste it into your PR) and
2) look for places where compressed form inputs should be used, but where they are currently not being used.
At a future time, a larger redesign of the Canvas sidebar forms is loosely planned where we'll look at making all panels visible by default. This is referring to the settings/options that are behind the 'plus in circle' icon buttons (like CSS and Container styles). It's worth noting that these panels do still need to be cleaned up in this initial effort.
As you work on an element, place your name next to it and add the PR link once it is ready for review
[x] Area chart (@andreadelrio)
[x] Bubble chart (@andreadelrio)
[ ] Coordinate plot (@andreadelrio)
[ ] Data table
[ ] Debug
[x] Donut chart (@andreadelrio)
[ ] Dropdown Filter
[x] Horizontal Bar chart (@andreadelrio)
[x] Horizontal Progress Bar (@andreadelrio)
[x] Horizontal Progress Pill (@andreadelrio)
[x] Image (@andreadelrio)
[x] Image repeat (@andreadelrio)
[x] Image reveal (@andreadelrio)
[x] Line chart (@andreadelrio)
[ ] Markdown
[ ] Metric
[x] Pie chart (@andreadelrio)
[ ] Progress Gauge
[ ] Progress Semicircle
[ ] Progress Wheel
[ ] Shape
[ ] Tilted pie chart
[ ] Time filter
[ ] Vertical Progress Bar
[ ] Vertical Progress Pill
[ ] Vertical bar chart
Please copy and paste this into your PRs
PR checklist
[ ] Form control and row properly uses the compressed property.
[ ] Fixed any EuiFormRow sibling spacing issues.
[ ] Fixed any compressed EuiFormRow children that didn't also have the compressed prop.
[ ] Changed EuiFormRowcompressed to display="compressed"
[ ] Changed EuiFormRowdisplayOnly to display="center" or display="centerCompressed"
The compressed EUI form inputs have been redesigned which has resulted in some small visual design 'breaks' and new opportunities to improve our form layouts.
Since each element has its own sidebar, let's attempt to divide the work up by element (listed below). There are two steps to cleaning up each Canvas element: 1) follow The checklist from the Meta cleanup issue (copy/paste it into your PR) and 2) look for places where compressed form inputs should be used, but where they are currently not being used.
At a future time, a larger redesign of the Canvas sidebar forms is loosely planned where we'll look at making all panels visible by default. This is referring to the settings/options that are behind the 'plus in circle' icon buttons (like CSS and Container styles). It's worth noting that these panels do still need to be cleaned up in this initial effort.
As you work on an element, place your name next to it and add the PR link once it is ready for review
Please copy and paste this into your PRs
PR checklist
compressed
property.compressed
prop.compressed
todisplay="compressed"
displayOnly
todisplay="center"
ordisplay="centerCompressed"
compressed
issues