search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.69k stars 8.12k forks source link

Tiny UI text issue in Management > Advanced settings page (Dark mode setting) #46622

Closed Titch990 closed 4 days ago

Titch990 commented 4 years ago

Kibana version: 7.4

Describe the bug:

Three One small thing about the dark mode setting and the related text.

  1. The UI text beside the dark mode setting says "A page refresh is required for the setting to be applied." but if you actually select dark mode, you get a helpful prompt that asks you to reload (not refresh) the page. Do we have a preferred word?

1. The dark mode setting is currently buried near the end of the Management > Advanced settings page, and below the warning banner saying "Be careful in here, these settings are for very advanced users only." Is that really the case? Would this setting be better nearer the top where it's visible, and perhaps above the warning banner? And is it a space setting or a personal setting? I understand that it may be better left as it is if it will affect every user of the space, but I assume it's a personal setting? If it really is a space setting, it could be helpful to mention the fact.

No longer applies: it's not buried, the warning is now global, it's a space setting in Advanced Settings now because dark mode can be triggered for the user in the profile menu.

The default value is shown as false but the toggle text is On/Off

No longer applies: the default is Disabled, the text is correct, and the control is appropriate.

Perhaps one for @gchaps?

elasticmachine commented 4 years ago

Pinging @elastic/kibana-app

gchaps commented 4 years ago

@cchaos Can you please comment on this issue?

cchaos commented 4 years ago

Yes we'd love to have dark mode be part of user settings and not buried under Advanced Settings. However, there's no architecture setup for user settings at the moment so this is the only place in can live for now.

I think all the text changes are viable. Advanced settings actually falls under @elastic/kibana-app-arch. I'll change the labels.

timroes commented 4 years ago

These are actually kind of three different issues in one. For (1) I would refer to https://github.com/elastic/kibana/issues/14791 for discussion. For (2) we can align the wording here, just would like an input from @gchaps which way we should rather go. (3) We currently show the technical default values, i.e. what’s actually saved, this would be an enhancement if we want to show default values kind of formatted

gchaps commented 4 years ago

For 2), I suggest this wording:

Enable dark mode for the Kibana UI. Reload the page to apply the setting.

For 3), Is the wording Default: false and Reset to default needed?

elasticmachine commented 2 years ago

Pinging @elastic/datavis (Team:DataVis)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-design (Team:Kibana-Design)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-stack-management (Team:Stack Management)

elasticmachine commented 2 years ago

Pinging @elastic/kibana-core (Team:Core)

afharo commented 2 years ago

I think 1) is similar to #108723.

elasticmachine commented 1 year ago

Pinging @elastic/appex-sharedux (Team:SharedUX)