search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.76k stars 8.15k forks source link

[Console] Do not provide completions for deprecated data frame transforms endpoints #48375

Closed hendrikmuhs closed 1 year ago

hendrikmuhs commented 4 years ago

For 7.5 the API /_data_frame/transforms/ has been deprecated and renamed to /transform/.

Completions have been updated with #47735, thank you!

However, it would be nice if the old endpoints /_data_frame/transforms/ could be blacklisted. We still provide completions for them.

(The REST API specs have "deprecated" in there name, maybe that can be used as indicator to blacklist those)

elasticmachine commented 4 years ago

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens commented 4 years ago

@hendrikmuhs thanks for opening this issue for discussion!

I see that the spec on ES side includes this key:

         ...
          "deprecated":{
            "version":"7.5.0",
            "description":"[_data_frame/transforms/] is deprecated, use [_transform/] in the future."
          }
          ...

Under the top-level url key. This is exactly the information we can use to show the user when it was deprecated and what we recommend they use instead. This can probably be displayed in the autocomplete drop-down.

So we would need to:

  1. Update the spec_to_console script to include the deprecated key mentioned above
  2. Update Console UI (in some way) to use this information - I think it will be easiest as a first pass to just indicate this in the autocomplete dropdown. Something like: https://codesandbox.io/s/relaxed-platform-t2ep7

I do want to add - this may be more complex than I am making it sound - updating Console's completion logic can be complex so perhaps inside the autcomplete is not the best place.

yuliacech commented 1 year ago

This endpoint is not displayed in the autocompletions anymore