elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

[Canvas] Add filters information to the UI #50984

Closed ryankeairns closed 1 year ago

ryankeairns commented 4 years ago

Describe the feature: Filters in Canvas are confusing at times and it's not obvious how to filter specific elements. There is a lot that could be done to improve this experience, especially as we begin embedding content from other Kibana applications, but let's start with clarifying which filters are being applied.

Describe a specific use case for the feature: As a user, I want to click on an element and easily see which filters are being applied.

Additionally, Canvas filters are applied globally by default but often I to apply filters per element(s). Filter groups allow you to achieve this behavior, but this feature is not very discoverable and could be clarified in the UI.

Phase 1 filter improvements

In a future phase these will be interactive, but for this first pass let's simply show users which filters are being applied to a workpad/element and provide a link to documentation regarding filter groups.

Note One way to view filters, currently, is by this expression filters | render as=debug. This initial phase would essentially add that information directly to the UI.

Meta This work is a subset of https://github.com/elastic/kibana/issues/50985

elasticmachine commented 4 years ago

Pinging @elastic/kibana-canvas (Team:Canvas)

ryankeairns commented 4 years ago

@andreadelrio when you have the time, please add a couple of screenshots to his issue. Maybe one for the element view and one for the workpad view. You can also link to the Figma doc/prototype for people to get more information. Thanks

andreadelrio commented 4 years ago

Workpad view - Dropdown option

workpad_filters_groupedByFilterGroups

Figma prototype: https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=40%3A305&scaling=min-zoom

Workpad view - Button group option

workpad_filters_buttonGroup_type

Figma prototype: https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=143%3A3004&scaling=min-zoom

Element view - Dropdown option (for a reference of the "button group" option see above)

element_filters_filterGroups

ryankeairns commented 4 years ago

@andreadelrio these looks great. Two small pieces of feedback:

Screenshot 2019-12-17 07 43 45

Thanks!

andreadelrio commented 4 years ago

Updated the Figma links replacing 'Exactly' with 'Dropdown'.

ryankeairns commented 4 years ago

@timductive @shaunmcgough @clintandrewhall @crob611

The phase 1 design work for displaying filter information is ready from the design side.

Thanks @andreadelrio !

maggieghamry commented 4 years ago

@ryankeairns can you please provide the latest UI design (if there are differences from https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=141%3A1080&scaling=min-zoom)?

I do have some questions about the aforementioned mockup, provided that is the latest:

cc @cqliu1 @crob611 @timductive

ryankeairns commented 4 years ago

@maggieghamry the last image in Andrea's post shows when an element is selected (it adds a third tab in the sidebar for Filters):

The Figma mockup is here: https://www.figma.com/file/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=143%3A3652

Here is a screenshot snippet from that link:

Screenshot 2020-04-01 16 12 53
maggieghamry commented 4 years ago

Thank you @ryankeairns !

ryankeairns commented 4 years ago

@maggieghamry I've updated the mockups to be more accurate (they now show actual filter elements :) ):

Updated mockups

The 'Group by' dropdown is hooked up and you can collapse/expand the bottom accordion in each view (for simplicity's sake, the top accordion does not expand/collapse in the prototype). If you collapse the bottom accordion, you'll also be able to see the 'View filter docs' link which also now takes you to the actual docs site.

https://www.figma.com/proto/Y1eiYAj9in7fRo7N60harh/canvas_filters_tab_v2?node-id=40%3A305&viewport=-2421%2C2694%2C0.4273872673511505&scaling=min-zoom

Screenshot from Figma link

Screenshot 2020-04-02 12 17 09
maggieghamry commented 4 years ago

Awesome, thanks so much for this @ryankeairns!

ThomThomson commented 1 year ago

Closing this for the time being as we are currently not prioritizing work to make the Canvas filtering experience more usable.