search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.52k stars 8.07k forks source link

Handling news feed errors #51629

Open liza-mae opened 4 years ago

liza-mae commented 4 years ago

Kibana version: master

Elasticsearch version: master

Server OS version: Linux

Browser version: Chrome

Browser OS version: Latest

Original install method (e.g. download page, yum, from source, etc.): snapshots

Description of the problem including expected versus actual behavior: I was looking into something else when I noticed this. There is an error being thrown in the browser console for the news feed since the feed does not exist. I do expect there to be an error thrown, since I am using a non-released version and the file is not there, but I was not sure if this the best way to do that. It throws an error on each page I visit, so it adds up, maybe it would be good to display one error at the header level where the news feed icon is? Although the file should be there at release, the other concern is would it do the same thing if say other errors occurred, like if the feed server was down?

Screenshot from 2019-11-23 18-45-03

elasticmachine commented 4 years ago

Pinging @elastic/kibana-stack-services (Team:Stack Services)

alexfrancoeur commented 4 years ago

Does this still occur in 7.5 prod?

liza-mae commented 4 years ago

I did not try 7.5 but I suspect it does happen there too, it still occurs on master.

alexfrancoeur commented 4 years ago

@rasroh has confirmed that this is only occurring on master, not 7.5

liza-mae commented 4 years ago

My concern when I opened the issue is how errors are handled not the error itself. As it could occur for example if the the newsfeed is unavailable, so it was more to make errors not print on the console but handled in a better way.

tsullivan commented 4 years ago

@liza-mae I could imagine an alternative that shows a toast message if the newsfeed is not able to come through. I don't think that would be a better experience though.

maybe it would be good to display one error at the header level where the news feed icon is

For the error use case, the newsfeed icon will display its "plain" treatment - no "unread" icon or anything to call out the icon. If the user clicks the envelope icon, they'll see a meaningful message telling them news couldn't be fetched. Some clients would expect that their Kibana is not able to fetch data from the outside Internet, and in our message we explain that if it's normal, then they can disable the newsfeed plugin in Kibana config.

Personally, I don't think they need to see any indication that there is a problem with retrieving news when the page first loads. If they try reading some news, we'll show them the friendly message about the problem.

The console message could be suppressed, but that definitely hurts the ability of anyone investigating to understand the problem better.