search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.77k stars 8.17k forks source link

Setting savedObjects:listingLimit to high values should trigger a warning #58733

Open flash1293 opened 4 years ago

flash1293 commented 4 years ago

Setting savedObjects:listingLimit to a number above 10k will fail listing requests with a "Result window is too large" on clusters not configuring max_result_window for the .kibana index (because all of these are fetched at once).

It should be either completely forbidden to do so or show a warning making you aware of this fact.

elasticmachine commented 2 years ago

Pinging @elastic/kibana-core (Team:Core)

pgayvallet commented 2 years ago

Since this issue was created, we're now supporting PIT search as a (strongly recommended) solution to search for more than 10k objects / to 'fetch all'. I wonder if we shouldn't just check that all usages of savedObjects:listingLimit are properly using PIT based searches?

elasticmachine commented 3 months ago

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

pgayvallet commented 3 months ago

This could also just be done by adding the proper validation to the registered setting, here:

https://github.com/elastic/kibana/blob/20ee30207f632658bdad1ffda242283e00fca2a9/src/plugins/saved_objects_finder/server/ui_settings.ts#L27-L37

Reassigning to the owning team