search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.63k stars 8.22k forks source link

Add option to `core.http.fetch` to allow requests to opt-out of default loading bar display #59484

Open joshdover opened 4 years ago

joshdover commented 4 years ago

In https://github.com/elastic/kibana/pull/59245, we added support to the Kibana Platform for showing the global loading bar any time a HTTP request was in progress.

The ideal UX is that this loading bar only shows to give the user feedback that something they're waiting to see is still pending. There are some requests that probably should not trigger this loading bar, for example:

We should opt-out of this behavior when the asSystemRequest option is true and possibly add another explicit option for this as well like hideFromLoadingIndicator or a more generic asBackgroundRequest.

elasticmachine commented 4 years ago

Pinging @elastic/kibana-platform (Team:Platform)

mshustov commented 4 years ago

We should opt-out of this behavior when the asSystemRequest option is true

👍

and possibly add another explicit option for this as well like hideFromLoadingIndicator or a more generic asBackgroundRequest.

let's postpone until necessary

joshdover commented 3 years ago

@elastic/kibana-design Are we planning on keeping this global loading indicator spinner around? If not, we will probably drop this issue.

ryankeairns commented 3 years ago

There have been some changes to the loading indicator. Now, we no longer show the bar across the top of the screen and, instead, swap in a spinner for the cluster logo. Additionally, iirc, we removed the loading bar from the log in related screens as well (now just relying on the small bar below the Elastic logo in the center of that page.

I'm not sure if this answers your question, but that is the current state of things including recent changes. Additionally, there is (will soon be?) an indicator appended to the last breadcrumb when queries are running in the background.

joshdover commented 3 years ago

I'm starting to notice that a UX problem where there is a more-or-less persistent loading spinner all the time when using Kibana in a production environment. I see this less when working locally. I think we may want to try to figure out the source of these requests and see if it makes sense to prioritize this issue to help fix to that UX issue. We may be able to find some of the problematic endpoints from the APM data we've been capturing on CI or when we start collecting APM data for internal clusters.

pgayvallet commented 4 months ago

@elastic/appex-sharedux do you know if that's something we might still want, or shall I just close this?