elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.72k stars 8.14k forks source link

(Accessibility) Multiple apps missing <h1> tag or content for <h1> tag or have nesting defects #61870

Open barlowm opened 4 years ago

barlowm commented 4 years ago

Dashboard page The initial panel with the dashboard name (sample data sets) is an H3, where others are H2s, creating a nesting mis-match. Screenshot at the bottom of the description.

Discover page

<discover-app class="app-container">
<h1 class="euiScreenReaderOnly"></h1>

Kibana Version: 7.6.2

OS: Windows 7

Browser: Chrome

Screen reader: [if relevant] N/A

Relevant WCAG Criteria: [#.#.# WCAG Criterion - Level A/AA/AAA](link to https://www.w3.org/WAI/WCAG21/quickref/) 2.4.6 - Headings and Labels - Level AA Headings and labels describe topic or purpose.

Screenshots

Screen Shot 2021-10-07 at 3 50 56 PM
1Copenut commented 2 years ago

This seems correlated with https://github.com/elastic/kibana/issues/42379. I'm in favor of setting focus on the H1 of a page view when we swap URLs using client-side routing, so screen readers announce the change properly. I'll do some more research, but I think these are related items.

elasticmachine commented 2 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter commented 2 years ago

I have removed the @elastic/kibana-presentation tag, because we have completed both the Canvas and Dashboard requests 👍

jughosta commented 2 years ago

Discover page: fixed in https://github.com/elastic/kibana/pull/129789

elasticmachine commented 2 years ago

Pinging @elastic/siem (Team:SIEM)

elasticmachine commented 2 years ago

Pinging @elastic/unified-observability (Team:Observability)

elasticmachine commented 2 years ago

Pinging @elastic/uptime (Team:uptime)

justinkambic commented 2 years ago

PR for Uptime here: https://github.com/elastic/kibana/pull/136559

EDIT: Uptime fix merged.

1Copenut commented 2 years ago

Machine Learning section has appropriate H1 tags in 8.5 main branch pulled to local machine on 12 September.

barlowm commented 3 weeks ago

Issue no longer observed in current version of Kibana (ver Kibana-8.13.2)