search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

Guard ES UI plugins against missing usageCollection dependency #63281

Open cjcenizal opened 4 years ago

cjcenizal commented 4 years ago

Some of our plugins declare usageCollection as an optional dependency, but internally don't type it as optional or guard against it if it's missing. See https://github.com/elastic/kibana/pull/63255/files#diff-6d18b1d695a8432b03b362bb913fd2faR28 or Console code for an example of the kind of changes we need to make.

Apps which need to be updated:

elasticmachine commented 4 years ago

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal commented 4 years ago

Note we can write tests per https://github.com/elastic/kibana/blob/master/src/core/TESTING.md#testing-optional-plugin-dependencies to verify these guards work as expected.

elasticmachine commented 2 months ago

Pinging @elastic/kibana-management (Team:Kibana Management)