search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.67k stars 8.23k forks source link

Fix branding updates missing in 7.8 BCs #68000

Closed alexfrancoeur closed 4 years ago

alexfrancoeur commented 4 years ago

@ryankeairns I just pulled up 7.8 BC4 and didn't see any of the branding updates from the PR https://github.com/elastic/kibana/pull/64712. Did https://github.com/elastic/kibana/pull/65416 not make the 7.8 deadline? Or did we revert some how?

image

Regardless, I believe we should backport and add as a blocker for 7.8. Is this something we can turnaround quickly?

cc: @VijayDoshi @kobelb

elasticmachine commented 4 years ago

Pinging @elastic/kibana-core-ui (Team:Core UI)

alexfrancoeur commented 4 years ago

@ryankeairns @myasonik @kobelb I'm confirming that this experience has not changed between BC1 and BC4. It looks like BC1 also did not get the branding changes.

ryankeairns commented 4 years ago

I see the backport for 7.x being merged 27 days ago, not sure how its not there.

ryankeairns commented 4 years ago

In the event we decide to go forward with it, I've created a 7.8. backport here: https://github.com/elastic/kibana/pull/68008

alexfrancoeur commented 4 years ago

@ryankeairns are we good to close or are we waiting on the next BC?

ryankeairns commented 4 years ago

Waits seems like good reminder!