Design for Solution Grouping on Spaces and Roles Pages

MichaelMarcialis commented 4 years ago

Based on early design enhancements suggested by the Core UI team for the Space page (as part of the customizable banner feature design), @legrego has begun implementing the suggested grouping of features/plugins by parent solution. He has requested additional design support to further flesh out this concept to:

Account for situations where all child features/plugins are not set to the same visibility setting and the solution accordion is closed.
- Currently, just the solution-level toggle would be visible, which may lead to some confusion, as it could be toggled on, while some child features/plugins within could be toggled off.
Provide a similar solution grouping design for the Role space privileges flyout.
- The solution-level action may be trickier to implement here, as it is not a binary state. Rather, the All/Read/None options may demand either a fourth "Custom" action or no solution-level action at all, to account for child feature/plugin states.

The desire is to get these changes in the 7.10 Kibana release.

elasticmachine commented 4 years ago

Pinging @elastic/kibana-core-ui (Team:Core UI)

alexfrancoeur commented 4 years ago

Cross linking: https://github.com/elastic/kibana/issues/54793

myasonik commented 4 years ago

@MichaelMarcialis What are your thoughts on moving away from Switches to Checkboxes?

This would let the top level group ones enter a third state of "some selected".

Screenshot of a checkbox in an indeterminate state

MichaelMarcialis commented 4 years ago

@MichaelMarcialis What are your thoughts on moving away from Switches to Checkboxes?

Yeah, that's not a bad idea. I'll play around with that idea in my next round of updates. Thanks!

legrego commented 4 years ago

@MichaelMarcialis I have a preliminary draft PR up as a starting point for design revisions: https://github.com/elastic/kibana/pull/74151

This does not [yet] include the checkboxes that @myasonik proposed

MichaelMarcialis commented 4 years ago

@MichaelMarcialis I have a preliminary draft PR up as a starting point for design revisions: #74151

This does not [yet] include the checkboxes that @myasonik proposed

Cool, I'll take a look at the PR. I'm hoping to wrap up my design concepts and review them with you later this week. Stay tuned for a calendar invite.

MichaelMarcialis commented 4 years ago

Heya, @legrego! Per our review meeting, I've updated the designs for this issue. These updates include:

Changing all references of "Write" back to "All".
Changing all references of "Apps" back to "Features".
Added example of an updated privilege summary.
Restored the ability to define how privileges should be handled for future feature releases (though in a slightly new way than it is handled now; please see Figma notes for details).

Please have a look at the design assets below when you get a moment. I've called out any questions or comments I have via notes below the various art boards in the mockups. Please let me know if these changes address your needs, or if you have any additional questions or feedback. You can leave me comments directly in Figma (via the commenting tool). Alternatively, I would be happy to schedule another review meeting if you feel one is needed. Thanks!

Design Assets

Screenshots

Edit Space

Create Role

elastic / kibana