search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.65k stars 8.23k forks source link

Align eslint rules for js & ts files #74385

Open mshustov opened 4 years ago

mshustov commented 4 years ago

Kibana codebase is migrating to typescript, but our linter setup is still out of sync for *.js & *.ts files. For example, we don't enforce a lot of import/* eslint-plugin rules for *.ts files. https://github.com/elastic/kibana/blob/master/packages/eslint-config-kibana/javascript.js#L92-L100 We need to sync rules for both *.js & *.ts files and fix already leaked violations.

elasticmachine commented 1 year ago

Pinging @elastic/kibana-operations (Team:Operations)

watson commented 1 year ago

It's been a while since this issue was raised, and we've come a long way in converting to TypeScript. Is this still a problem, or can we close this issue?

mistic commented 1 year ago

I think this issue is still applying to some options missing sync between both envs. Not high priority though