elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.66k stars 8.23k forks source link

[APM] Clicking error count in waterfall item causes full page reload #82154

Open smith opened 4 years ago

smith commented 4 years ago

On a waterfall item with errors, clicking the error count takes the user to the errors overview filtered by the trace/transaction.

Clicking this should navigate to the overview but causes a full page reload. This is because the ErrorCount component has an onClick handler that does a stopPropagation, and the WaterfallItem container also does stopPropagation.

These stopPropagation calls are there to stop the flyout from opening when navigating, but they also cause the handlers from RedirectAppLinks to not be called.

Make it so the flyout still opens when needed and the navigation to the error overview happens without a full page reload.

elasticmachine commented 4 years ago

Pinging @elastic/apm-ui (Team:apm)

botelastic[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.