Closed flash1293 closed 3 years ago
Pinging @elastic/kibana-app (Team:KibanaApp)
Had the same error using 2 beats provided indices, source fetching, no rollupdata UPDATE: there was one rollup index involved, so this was the reason for this error
This was the Request:
The problem here is that we're requesting stored_fields
explicitly in 7.12 for those "non leaf" fields in the rollup index. Beforehand we've requested *
. I'll sync with @lukeelmers later and talk about that.
I've discussed this with Luke offline. Given that we don't see much use-case in that specific combination of having stored_fields
and rollup v1 at the same time, we discussed that our preferred way would be to simply not sending stored_fields
with an explicit list when a rollup index pattern is used. Fields inside a rollup index pattern are anyway never stored fields and the chance we're mixing it with a live index pattern that uses stored fields that are not mapped (and thus not working in the fields API) is rather low.
I.e. we would like to make https://github.com/elastic/kibana/blob/master/src/plugins/data/common/search/search_source/search_source.ts#L619 conditional to only be called on non rollup index patterns.
Since we have no urgency for 7.12 to get this in, I want to ask @ppisljar if app services team could just take that into their planning for 7.13, since it's a rather minor adjustment to the search source?
Pinging @elastic/kibana-app-services (Team:AppServices)
isn't this a regression introduced in 7.12 ? if so we should probably try to fix it ASAP (and our fix it week is next week).
Yes it's a regression introduced in 7.12, though it should be a really nieche that ever have a valid scenario for that and I think it only fails in Discover (as the only consumer of raw documents in search source + rollup index patterns atm?) and if we fix it as above, we don't restore previous behavior, but would disable stored_fields with rollup index patterns (which to Luke and my impression is fine, but we can sync about it again if you have doubts about that).
I'm not able to reproduce this. It looks to me like we're requesting "stored_fields": ["*"]
even for rollup index patterns with discover:searchFieldsFromSource
enabled, and the query succeeds.
Kibana version: 7.12
Describe the bug: When trying to view a rollup index pattern in Discover, the request fails if the fields API is not enabled (_source fetching)
Steps to reproduce:
Expected behavior: Request works and shows the technical rollup documents
Screenshots (if relevant):