search

elastic / kibana

Your window into the Elastic Stack
https://www.elastic.co/products/kibana
Other
19.6k stars 8.21k forks source link

[Maps] Time picker still shows when time field not enabled on index pattern #92909

Open kindsun opened 3 years ago

kindsun commented 3 years ago

Index patterns without a time field enabled cause the timepicker to show up as off in visualizations since limiting data by time isn't applicable:

image

In Maps it's a little trickier since there can be multiple index patterns present, some of which might have a time field and some of which don't. This means when a layer is added based on an index pattern with no time field, the Timepicker still appears but has no effect on the index pattern layer(s) without time fields. This is however consistent with Dashboard which has a similar challenge of managing multiple visualizations deriving from different index patterns:

image

Ultimately, Maps is consistent with Dashboard, so this is very likely not a bug, but ideally there would be some indication to the user that the Timepicker isn't relevant for some or all layers present without Time fields.

elasticmachine commented 3 years ago

Pinging @elastic/kibana-gis (Team:Geo)

elasticmachine commented 3 years ago

Pinging @elastic/kibana-presentation (Team:Presentation)

thomasneirynck commented 3 years ago

Maybe not a "bug" perse, but I do agree it is a real challenge.

Layers can have capabilities and depending on those capabilities, one or more features of the global Kibana-chrome is not applicable.

Time-picker is a good example (= this ticket). Another one in the context of Maps is that the map can consist of layers that are not filterable/queryable. For those it would not be relevant to show the query and/or filter bar. https://github.com/elastic/kibana/issues/91865

Adding presentations-team label, since challenge is similar there. cc @clintandrewhall

nreese commented 3 years ago

The legend has a clock icon next to layers filtered by time picker to clearify which layers are filtered by the time picker

Screen Shot 2021-02-25 at 3 18 24 PM
kindsun commented 3 years ago

@nreese Good point, but it's an inclusive-only indicator. It helps you differentiate when you have multiple layers, some of which are controlled by the Time picker and some of which aren't. When you have a map with just one or more index patterns without time fields, it just looks like this:

image

So really no indication that the time filter isn't useful or doesn't apply to the layer.

nreese commented 3 years ago

So really no indication that the time filter isn't useful or doesn't apply to the layer.

In the case where no layers are using the time picker, then it should be off like in visualizations.

nreese commented 3 years ago

Linking to lens issue about what to do about time picker when there is no default time fields https://github.com/elastic/kibana/issues/72502